Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Support job middleware for queued notifications #30070

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@vigneshgurusamy
Copy link
Contributor

commented Sep 23, 2019

Implementation for issue #30057

@vigneshgurusamy vigneshgurusamy marked this pull request as ready for review Sep 23, 2019
@driesvints driesvints changed the title [6.0] Support job middleware for queued notifications [6.x] Support job middleware for queued notifications Sep 23, 2019
@taylorotwell

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

I wouldn't have a property at all. Just check the method.

@vigneshgurusamy

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

@taylorotwell Both Job and Notification classes use Queuable trait which implements through() method to set middlewares.

If we remove the property check, we will lose the ability to set middleware via through() method.

Still, users will be able to call through() method from queued notification but middlewares won't be added to queued notification job from the property.

So how do we solve this?

@taylorotwell taylorotwell merged commit 2a2dce5 into laravel:6.x Sep 30, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
i-bajrai added a commit to i-bajrai/framework that referenced this pull request Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.