Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Vendor publish improvement #30408

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@SherSpock
Copy link
Contributor

SherSpock commented Oct 23, 2019

Fixes #23169

@SherSpock SherSpock force-pushed the SherSpock:vendor-publish-bug-fix branch 2 times, most recently from bf4cf1a to c32e47e Oct 23, 2019
@SherSpock SherSpock force-pushed the SherSpock:vendor-publish-bug-fix branch from c32e47e to 76b39de Oct 23, 2019
@GrahamCampbell GrahamCampbell changed the title Vendor publish bug fix/improvement [6.x] Vendor publish improvement Oct 24, 2019
*
* @var bool
*/
protected $published;

This comment has been minimized.

Copy link
@netpok

netpok Oct 24, 2019

Contributor

Couldn't this be just a local variable where it's used?

$this->published = true;
}
if ($this->published) {

This comment has been minimized.

Copy link
@netpok

netpok Oct 24, 2019

Contributor

A newline could be here to improve readability.

@taylorotwell taylorotwell merged commit 76b39de into laravel:6.x Oct 24, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.