Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[5.8] Accept underscores in the URL validator, as the URL will load #30417
We came across an issue in one of our Laravel apps (currently using 5.8) in which a valid URL was being treated as invalid by the 'url' validation rule, due to the presence of an underscore in the domain name (which, while unconventional, still works). Laravel's validateUrl() method documentation states that it is based on Symfony's UrlValidator. Symfony recently released a fix for this same issue here: symfony/symfony@ad89564 (see related discussion here: symfony/symfony#32506).
I copied the pattern update into Laravel's validateUrl() method and updated the corresponding tests accordingly.
(I realize we are just out of the published window for bug fixes on 5.8, but I'm hoping we can squeeze in one this small anyway, as it is compatible with the current release. I can resubmit to the 6.x branch if necessary.)