Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Use isset but not !empty for changing redis database #30420

Merged
merged 2 commits into from Oct 27, 2019

Conversation

@davidhhuan
Copy link
Contributor

davidhhuan commented Oct 25, 2019

No description provided.

@GrahamCampbell GrahamCampbell changed the title Use isset but not !empty for changing redis database [6.x] Use isset but not !empty for changing redis database Oct 25, 2019
@netpok

This comment has been minimized.

Copy link
Contributor

netpok commented Oct 25, 2019

But why? Could you provide some information? Does this fix a bug?

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Oct 25, 2019

I assume this allows explicitly selecting connection 0, which would usually already be the client's default.

@netpok

This comment has been minimized.

Copy link
Contributor

netpok commented Oct 26, 2019

Great, I did not know.

@davidhhuan Please provide a description to prevent the "...it lacks sufficient explanation..." answer.

@taylorotwell taylorotwell merged commit 12b8a6a into laravel:6.x Oct 27, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.