Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix implementation of spop in PHPRedis implementation #30546

Merged
merged 1 commit into from Nov 11, 2019

Conversation

@Miljan9602
Copy link
Contributor

Miljan9602 commented Nov 8, 2019

Hello,
You guys forgot to forward count argument to Redis, and, also, 1 should be default, instead of null.

@GrahamCampbell GrahamCampbell changed the title Fix implementation of spop in PHPRedis implementation [6.x] Fix implementation of spop in PHPRedis implementation Nov 8, 2019
@taylorotwell taylorotwell merged commit 5e10c01 into laravel:6.x Nov 11, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.