Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fixed breaking compatability with multi-schema postgres #30562

Merged
merged 6 commits into from Nov 11, 2019

Conversation

@raymondtri
Copy link
Contributor

raymondtri commented Nov 11, 2019

This extends #30555 with added suggestions from Taylor Otwell regarding handling strings or arrays, while persisting the old method signature to make it non-breaking.

@mfn

This comment has been minimized.

Copy link
Contributor

mfn commented Nov 11, 2019

TODO

@taylorotwell taylorotwell merged commit 7bf252e into laravel:6.x Nov 11, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@raymondtri raymondtri deleted the raymondtri:6.x-multischema_support branch Nov 11, 2019
@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Nov 12, 2019

@mfn think this one can just be documented? Don't feel it's necessary to add every single config option to the config file?

@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Nov 12, 2019

Or it can be. I'm a bit indifferent tbh.

@mfn

This comment has been minimized.

Copy link
Contributor

mfn commented Nov 12, 2019

😄

IMHO it's most easily discovered when it's already parts of the blueprint configuration 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.