Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Added head method to router to allow implicit call via HEAD HTTP method #30646

Merged
merged 2 commits into from Nov 22, 2019

Conversation

@samstreet
Copy link
Contributor

samstreet commented Nov 21, 2019

Backwards compatible, but exposes an implicit method for those developing a REST API and don't want to have to rely on get.

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Nov 21, 2019

Please also update the phpdoc in the the route facade.

@samstreet samstreet force-pushed the samstreet:6.x branch from d9a3556 to 84c7b3e Nov 21, 2019
@samstreet

This comment has been minimized.

Copy link
Contributor Author

samstreet commented Nov 21, 2019

@GrahamCampbell I don't use facades, so please advise if I haven't updated the correct file.

@taylorotwell taylorotwell merged commit 5e17914 into laravel:6.x Nov 22, 2019
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/styleci/pr Issues have been identified with 1 file
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
driesvints added a commit that referenced this pull request Nov 28, 2019
This reverts #30646 because it's incomplete and currently breaks the route:list command.

Closes #30708
taylorotwell added a commit that referenced this pull request Nov 29, 2019
This reverts #30646 because it's incomplete and currently breaks the route:list command.

Closes #30708
taylorotwell added a commit to illuminate/routing that referenced this pull request Nov 29, 2019
This reverts laravel/framework#30646 because it's incomplete and currently breaks the route:list command.

Closes laravel/framework#30708
taylorotwell added a commit to illuminate/support that referenced this pull request Nov 29, 2019
This reverts laravel/framework#30646 because it's incomplete and currently breaks the route:list command.

Closes laravel/framework#30708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.