Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[6.x] Fix RouteUrlGenerator accepting empty string for required paramenter #30714
#30659 fixed RouteUrlGenerator not failing when a required parameter is not passed but it's still not failing if a required parameter is passed empty.
I don't think this could be considered an expected behaviour since normally required means set and not empty.
My PR checks if the required parameter is set and it's not an empty string, if this check fails it will look for default Parameter and as last step checks if parameter was optional.
Test failing was the one with optional parameter passed without key:
What I needed to do is removing empty parameter from