Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix explicit models in string-based database validation rules #30790

Merged
merged 3 commits into from Dec 9, 2019

Conversation

@clugg
Copy link
Contributor

clugg commented Dec 9, 2019

This PR fixes issue #30726, caused by table names being resolved differently between the Exists and Unique rule instances as compared to the validateExists and validateUnique rule methods in ValidatesAttributes. It maintains backwards compatibility with the existing functionality of being able to specify a connection using a dot as a separator.

@clugg clugg changed the title [6.x] Fix explicit models in string-based database validation rules (fixes #30726) [6.x] Fix explicit models in string-based database validation rules Dec 9, 2019
@taylorotwell taylorotwell merged commit 5728c66 into laravel:6.x Dec 9, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.