Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix non-eloquent model validation #30840

Merged
merged 3 commits into from Dec 16, 2019
Merged

Conversation

@bounoable
Copy link
Contributor

bounoable commented Dec 14, 2019

5728c66 broke validation for models/entities that don't inherit from Laravels Model class (laravel-doctrine), because parseTable assumes an Eloquent Model if the provided table/model string is a class. This PR adds a check before instantiating the class and falls back to the previous behavior if it's not an Eloquent Model.

bounoable and others added 2 commits Dec 14, 2019
@taylorotwell taylorotwell merged commit 7f6fe8c into laravel:6.x Dec 16, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.