[6.x] Handle passing too many arguments to @slot
#30893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add an extra conditional if the number of arguments is greater than 2, and throw an exception telling the user they've passed too many arguments to the `@slot`. also simplify an "else if" to an "elseif"
GrahamCampbell
changed the title
@slot@slot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Problem
Passing too many arguments to a
@slotdirective will start an output buffer without closing it.This can cause the cryptic "Test code or tested code did not (only) close its own output buffers" error message.
Solution
This PR checks to see if more than 2 parameters have been passed to the
@slot, and throws an Exception with an explanation of the issue.