Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add mixin support to Eloquent builder #30978

Merged
merged 1 commit into from Jan 2, 2020
Merged

Conversation

@imliam
Copy link
Contributor

imliam commented Dec 30, 2019

The Eloquent Builder class already supports macros to be added to it without using the Macroable trait: \Illuminate\Database\Eloquent\Builder::macro(...)

This PR adds similar support to allow the "mixin" static method to be used to add multiple macros at once using a class: \Illuminate\Database\Eloquent\Builder::mixin(...)

@imliam imliam changed the base branch from master to 6.x Dec 30, 2019
@imliam imliam changed the title Add mixin support to Eloquent builder [6.x] Add mixin support to Eloquent builder Dec 30, 2019
@taylorotwell taylorotwell merged commit 7cb1ff6 into laravel:6.x Jan 2, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mikemand

This comment has been minimized.

Copy link
Contributor

mikemand commented Jan 7, 2020

Thank you, thank you, thank you! This has been a bug since April 2019 and before: #28262

@imanghafoori1

This comment has been minimized.

Copy link
Contributor

imanghafoori1 commented Jan 8, 2020

Is there any test for this feature ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.