Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Make the Redis Connection macroable #31020

Merged
merged 1 commit into from Jan 5, 2020

Conversation

@matt-allan
Copy link
Contributor

matt-allan commented Jan 3, 2020

This PR makes the Redis connection macroable.

I personally need this because I wrote a circuit breaker and I would like to be able to use it in a similar manner to Redis::throttle and Redis::funnel.

I imagine macros would also be helpful for registering custom Lua scripts as commands, overriding funnel with an implementation using the RedLock algorithm, adding a SCAN abstraction that works the same across predis and phpredis, etc.

If a macro is not registered we fallback to executing a command on the client so this should not be a breaking change.

@GrahamCampbell GrahamCampbell changed the title Make the Redis Connection macroable [6.x] Make the Redis Connection macroable Jan 4, 2020
@taylorotwell taylorotwell merged commit c788434 into laravel:6.x Jan 5, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matt-allan matt-allan deleted the matt-allan:redis-connection-macroable branch Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.