Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Support dispatchAfterResponse in BusFake #31418

Merged
merged 2 commits into from Feb 10, 2020
Merged

Conversation

@Jigsaw5279
Copy link
Contributor

Jigsaw5279 commented Feb 10, 2020

This PR aims to solve the issue I reported in #31416 by adding the required methods to the BusFake

I'm not sure wether separating them into a different array of commands was necessary, but I felt like you should be able to assert that a job will be executed after teminating the request instead of whenever.

@Jigsaw5279 Jigsaw5279 requested a review from taylorotwell Feb 10, 2020
@taylorotwell taylorotwell merged commit ce6465d into laravel:6.x Feb 10, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Jigsaw5279 Jigsaw5279 deleted the tenado-gmbh:bugfix/busfake-dispatch-after-response branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.