Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Allow private-encrypted pusher channels #31559

Merged
merged 6 commits into from Feb 24, 2020
Merged

Conversation

@onurkose
Copy link
Contributor

onurkose commented Feb 22, 2020

pusher/pusher-php-server allows private-encrypted channels but broadcaster implementation missing the definitions so it couldn't pass the broadcasting/auth guard.

pusher/pusher-php-server allows private-encrypted channels but broadcaster implementation missing the definitions so it couldn't pass the broadcasting/auth guard.
@GrahamCampbell GrahamCampbell changed the title Update UsePusherChannelConventions.php [6.x] Allow private-encrypted pusher channels Feb 22, 2020
@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Feb 22, 2020

Thanks for this PR, but the implementation doesn't look quite right.

@GrahamCampbell

This comment has been minimized.

Copy link
Member

GrahamCampbell commented Feb 22, 2020

I've corrected this. Your implementation incorrectly replaced private-encrypted-private-123 with 123 instead of private-123.

@onurkose

This comment has been minimized.

Copy link
Contributor Author

onurkose commented Feb 22, 2020

Great, I was trying to find a better way just like yours.

GrahamCampbell and others added 4 commits Feb 22, 2020
Another requirement for Pusher's private encrypted channels.
@taylorotwell taylorotwell merged commit 520188c into laravel:6.x Feb 24, 2020
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@onurkose

This comment has been minimized.

Copy link
Contributor Author

onurkose commented Feb 24, 2020

This is my first contribution after many years of using the framework, so thank all you guys for such a great work.

@driesvints

This comment has been minimized.

Copy link
Member

driesvints commented Feb 25, 2020

@onurkose thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.