Skip to content

[7.x] Fix a bug with slash prefix - #31760

Merged
taylorotwell merged 1 commit into
7.xfrom
fix-bug-with-slash-prefix
Mar 5, 2020
Merged

[7.x] Fix a bug with slash prefix#31760
taylorotwell merged 1 commit into
7.xfrom
fix-bug-with-slash-prefix

Conversation

@driesvints

@driesvints driesvints commented Mar 5, 2020

Copy link
Copy Markdown
Member

Fixes an issue where the prefix could be a slash. Can maybe use some polishing.

Route::prefix('/')->group(function ($router) {
    $router->view('welcome/user', 'welcome');
});

Fixes #31759

@crynobone

Copy link
Copy Markdown
Member

@driesvints tested locally 👍

Comment thread src/Illuminate/Routing/CompiledRouteCollection.php Outdated
Comment thread src/Illuminate/Routing/CompiledRouteCollection.php Outdated
@driesvints
driesvints force-pushed the fix-bug-with-slash-prefix branch from 25d50ed to c087ffe Compare March 5, 2020 13:55
@taylorotwell
taylorotwell merged commit b3adb67 into 7.x Mar 5, 2020
@GrahamCampbell
GrahamCampbell deleted the fix-bug-with-slash-prefix branch March 5, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route prefix get truncated when using ->prefix('/') fluent routing registration

3 participants