Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix incompatible contract for Mail Facade #31809

Merged
merged 1 commit into from
Mar 6, 2020
Merged

[7.x] Fix incompatible contract for Mail Facade #31809

merged 1 commit into from
Mar 6, 2020

Conversation

Hasnayeen
Copy link
Contributor

Illuminate\Notifications\Channels\MailChannel has been updated in v7.x to use Illuminate\Contracts\Mail\Factory contract instead of Illuminate\Contracts\Mail\Mailer but Illuminate\Support\Testing\Fakes\MailFake doesn't implement Illuminate\Contracts\Mail\Factory which results in following error
TypeError: Argument 1 passed to Illuminate\Notifications\Channels\MailChannel::__construct() must implement interface Illuminate\Contracts\Mail\Factory, instance of Illuminate\Support\Testing\Fakes\MailFake given.

This pr fix the above issue.

@driesvints
Copy link
Member

This seems the same one like #31752.

I suspect you're using notifications?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants