Skip to content

[6.x] Fix phpredis "zadd" and "exists" on cluster#31838

Merged
taylorotwell merged 1 commit intolaravel:6.xfrom
themsaid:pr28843
Mar 8, 2020
Merged

[6.x] Fix phpredis "zadd" and "exists" on cluster#31838
taylorotwell merged 1 commit intolaravel:6.xfrom
themsaid:pr28843

Conversation

@themsaid
Copy link
Copy Markdown
Member

@themsaid themsaid commented Mar 8, 2020

This PR fixes #29637 and #30473

By not using executeRaw, the cluster connection will call the correct redis command.

@stancl
Copy link
Copy Markdown
Contributor

stancl commented Mar 12, 2020

@themsaid

Removing exists() is a breaking change, because the parameters are now different. Previously passing multiple arguments was okay, but now only one argument can be passed.

My package's tests were passing and now they are failing because of that. See this: https://travis-ci.com/github/stancl/tenancy/builds/152720978#L2193

And this: https://github.com/stancl/tenancy/blob/2.x/src/StorageDrivers/RedisStorageDriver.php#L59-L61

@themsaid
Copy link
Copy Markdown
Member Author

@stancl but I can pass multiple keys no problem. Maybe you’re using a really old phpredis version?

@stancl
Copy link
Copy Markdown
Contributor

stancl commented Mar 12, 2020

@themsaid Hmm, possible. Seems like I'm using 3.1.6 in that build and the latest version is 5.2.0.

I guess I can find a way to update that, but I wonder if this would cause issues for others as well, since (for example) my code is a package.

But I see that you specified ^4.0 as phpredis version constraint, so I'll try with phpredis 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants