[7.x] Match Symfony's Command::setHidden declaration#31840
Merged
taylorotwell merged 1 commit intoMar 8, 2020
Conversation
Symfony\Component\Console\Command\Command::setHidden(bool $hidden) symfony/console@101b74f
Contributor
Author
|
This is a fine fix as method parameter signatures should match if possible. But, my actual problem was that I am a Tinkerwell noob and didn't link my correct PHP version. 🤦♂ Meaning that the error was happening because of PHP 7.1.... |
|
I'm still experiencing this problem. Brand new install of Laravel v7. |
Collaborator
|
This happens if you have the wrong version of Symfony in your vendor folder, possibly due to a global install. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source of declaration mismatch:
Symfony\Component\Console\Command\Command::setHidden(bool $hidden)-vendor/symfony/console/Command/Command.php:456symfony/console@101b74f
After installing Laravel v7.0.7 on PHP 7.3.12 via
laravel newI got a few declaration mismatches with Symfony. Two in Carbon which appear to be documented and with a fix pending here: briannesbitt/Carbon#2033 and this one inIlluminate\Console\Command::setHidden($hidden)with a mismatch toSymfony\Component\Console\Command\Command::setHidden(bool $hidden)Installed Symfony is v5.0.5. Errors were displayed in Tinkerwell.
This very well may be a PHP 7.3 issue. Cannot replicate using PHP 7.4