[7.x] Enabling Windows absolute paths normalizing #31985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
| @@ -147,6 +147,13 @@ class Application extends Container implements ApplicationContract, CachesConfig | |||
| */ | |||
| protected $namespace; | |||
|
|
|||
| /** | |||
| * The application namespace. | |||
There was a problem hiding this comment.
I guess this comment might be wrong
There was a problem hiding this comment.
Of course. Fixed.
This was referenced May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our devs are working on Windows machines and we've found that there's a big problem with normalizing cache path when it's an absolute path. With Unix systems it's great, because in these cases Laravel only needs to check if a string starts with
'/'.Withn Windows it could be more problematic, because absolute path starts with drive capital letter and a colon, eg.'C:'.That's why I added
absolutePathPrefixesarray that could be modified for everyone. In default mode it's not affecting anything else.