[7.x] Blade newline fixes#32026
Merged
Merged
Conversation
Contributor
|
@GrahamCampbell I still receive \r\n on windows. |
Collaborator
Author
|
Probably because you have git configured to check out the code using Windows style newlines instead of unix style. |
Contributor
|
@GrahamCampbell Ok but still it should replace the windows-style with Unix before saving to storage/views, so that the cached views will never have windows style. |
Collaborator
Author
|
Laravel's job is not to interfeer with the newlines you used in your own code. |
Contributor
|
hmm... let's find the root cause of that. I suspect what is going on... (0_o) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behaviour of an app should not be different depending on what OS it is deployed on. Most deployments checkout code by downloading a zip of the repo, which will have the blade views with unix style newlines. Dynamically generated stuff should also new unix style newlines, so that responses returned to users have unix style newlines, and not some a mix of unix and windows style on Windows server deployments.