Skip to content

[7.x] Add default value to HtmlString constructor#32290

Merged
taylorotwell merged 1 commit into
laravel:7.xfrom
mvdnbrk:htmlstring-default-value
Apr 8, 2020
Merged

[7.x] Add default value to HtmlString constructor#32290
taylorotwell merged 1 commit into
laravel:7.xfrom
mvdnbrk:htmlstring-default-value

Conversation

@mvdnbrk

@mvdnbrk mvdnbrk commented Apr 8, 2020

Copy link
Copy Markdown
Contributor

This PR adds a default value to the Illuminate\Support\HtmlString constructor.

new HtmlString;

// vs

new HtmlString('');

Example use case:

public function getContent(): HtmlString
{
    if (empty($this->attribute) {
        return new HtmlString;
        // vs
        return new HtmlString('');
    }

    return new HtmlString($this->attribute);
}

@taylorotwell
taylorotwell merged commit 3e07f46 into laravel:7.x Apr 8, 2020
@mvdnbrk

mvdnbrk commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

@taylorotwell Thank you!

@mvdnbrk
mvdnbrk deleted the htmlstring-default-value branch April 8, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants