[6.x] Duplicated mailable in-memory data attachments with different names#32392
Merged
taylorotwell merged 3 commits intolaravel:6.xfrom Apr 15, 2020
Merged
Conversation
mnabialek
changed the title
mnabialek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what was the exact reason of fix in 3c8ccc2 but I think it should be possible to use same data as attachment if they have different name.
Imagine such scenario - when you send daily or montly reports with some data in multiple files but sometimes some of those files can contain same data. At the moment some of files will be ignored and it can be really confusing both for developer and end-users why they won't receive some report files.
If approved I believe similar change should be done for disk attachments.