Skip to content

[7.x] Add getGrammar into passthru in Eloquent builder - #32412

Merged
taylorotwell merged 1 commit into
laravel:7.xfrom
miklcct:getGrammar_passthru
Apr 17, 2020
Merged

taylorotwell merged 1 commit into
laravel:7.xfrom
miklcct:getGrammar_passthru

Conversation

@miklcct

@miklcct miklcct commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

This fix a bug when getGrammar() is called on the Eloquent builder which should be passed thru but not.

@GrahamCampbell

Copy link
Copy Markdown
Collaborator

What is your use case for needing the grammar?

@miklcct

miklcct commented Apr 17, 2020

Copy link
Copy Markdown
Contributor Author

I need the grammar to build some raw SQL in order to have custom expression in select or where clauses with columns specified.

@GrahamCampbell GrahamCampbell changed the title [7.x] add getGrammar into passthru in Eloquent builder [7.x] Add getGrammar into passthru in Eloquent builder Apr 17, 2020
@taylorotwell
taylorotwell merged commit ca71214 into laravel:7.x Apr 17, 2020
@miklcct
miklcct deleted the getGrammar_passthru branch April 26, 2020 06:27
salmanarshad321 pushed a commit to salmanarshad321/framework that referenced this pull request Sep 23, 2026
[7.x] Add getGrammar into passthru in Eloquent builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants