[6.x] Fix firstWhere behavior for relations#32525
Merged
Merged
Conversation
driesvints
force-pushed
the
fix-first-where
branch
from
38bd487 to
62b2f94
Compare
driesvints
force-pushed
the
fix-first-where
branch
from
62b2f94 to
c55f1b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
firstWherebehavior forBelongsToManyrelations andHasManyThrough. Previous behavior caused attributes from the pivot table to also be placed on the retrieved model and subsequently overwrite attributes.Fixes #32464