[7.x] Added check to avoid endless loop in MailManager::createTransport#32549
Merged
taylorotwell merged 5 commits intolaravel:7.xfrom Apr 26, 2020
Merged
Conversation
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading to Laravel 7 I found out that a misconfiguration of the new
mail.mailers.*config can lead to an endless loop inMailManager::createTransport()which is caused by an emptytransport-key inmail.mailers.{ANY_MAILER}.This happed to us when we were migrating or multi-tenant SMTP configuration to new mailers pattern and as we used
driverinstead oftransportin the configuration ran into a memory overflow due to the described endless loop.This MR adds a check, as well as tests for it, to ensure that
transport-key in$configinMailManager::createTransport()is not empty, where not empty means unequal tonull,""and" ".This MR points the user to the right place of misconfiguration and does not break any existing features.