Repository navigation
[7.x] Add Callbacks with Output to Console Schedule - #32633
Merged
taylorotwell merged 2 commits intoMay 3, 2020
Merged
Conversation
GrahamCampbell
requested changes
May 1, 2020
Member
|
I made a few tweaks to this. The "output" is injected into the Closure using the container->call() method like the other callbacks. This means you must name the variable $output. Which leads me to my next point, I think these methods shouldn't really be called directly and in 8.x I'm going to make the standard |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Our health check provider allows POSTing output logs. Currently there's no built in way to do this. Instead of trying to figure out a one-size-fits-all to POST, my proposal is to use callbacks. This way you can use any kind of HTTP library you want, attach additional data, filter the output, etc.
I took the
$onlyIfOutputExistsargument from theemailOutputTo()command, so you can optionally only run the callback if an output was generated.There are 4 callable methods, similar to the ping URL methods:
thenWithOutput()thenIfWithOutput()onSuccessWithOutput()onFailureWithOutput()Example: