[6.x] Fix testing commands that do not resolve 'OutputStyle::class' from the container#32687
Merged
taylorotwell merged 1 commit intolaravel:6.xfrom May 7, 2020
Merged
Conversation
Member
|
I'm curious what command you are actually trying to test? If it's not a Laravel command, I'm curious if we should really expect Laravel's helpers to be able to test it, etc. |
Contributor
Author
|
I am working with a command derived from a parent that is part of a package originally intended for Symfony. I can your reasoning, this is an edge case and I can easily work around the issue, it would have been nice for it to work out of the box. Also, this is part of the reason the output dumping PR I submitted failed for you, you were trying to test 'list' a Symfony command. (the other reason is it's crappy code that shouldn't have been a PR in the first place 🙈, revised PR coming) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that look for output (via
expectsOutput) from commands that do not resolveOutputStylefrom the application container fail unexpectedly.An example of this is the default Symfony 'list' command, this command is not a descendant of
Illuminate\Console\Commandand therefore doesn't resolve its output interface from the container.You can verify the behaviour by adding the following test to the stock FeatureTest:
This tests the
listcommand, which will fail if run against the current codebase but pass against this fix.This shouldn't break anything as we're simply passing the mock directly to the kernels call method as opposed to relying on it being resolved.
If accepted, I'm guessing this can also be merged up?