[7.x] Added client or server error definition in the Http

[andrey-helldar]

The Http facade has method successful, the return status of a successful request. But in case you need to determine the error, you have to use one of the following options:

if (! $response->successful()) { }
// or
if ($response->clientError() || serverError()) { }

Therefore, I propose adding method failed, which makes it possible to more clearly identify errors:

if ($response->failed()) { }

[driesvints]

Why don't we negate the value of successful? This seems like an opening for edge cases to leak in.

[andrey-helldar]

Why don't we negate the value of successful? This seems like an opening for edge cases to leak in.

Because failed means a client or server error. And the successful defines status codes from 200 to 299.
This means that in case of negation, the returned code, for example, 301 will be considered an error, and this is not correct.

Therefore, the option I proposed:

return $this->serverError() || $this->clientError();

looks better than:

return ! $this->successful() && ! $this->redirect();

Also, in the denial of successful answers and redirects, there is no code handler 100-199, which are defined by the specification.