Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Add boolean to types that don't need character options #32716

Merged
merged 1 commit into from
May 7, 2020
Merged

[6.x] Add boolean to types that don't need character options #32716

merged 1 commit into from
May 7, 2020

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented May 7, 2020

I was glad to see #30539 got fixed by fccdf7c, but after I updated Laravel to 7.10.3 my issue was still present. I was changing a varchar to a boolean and that one is missing from the list of types that don't need character options. This PR adds it to that list!

@driesvints
Copy link
Member

Probably needs to go to 6.x?

@JaZo JaZo changed the base branch from 7.x to 6.x May 7, 2020 12:31
@JaZo JaZo changed the title [7.x] Add boolean to types that don't need character options [6.x] Add boolean to types that don't need character options May 7, 2020
@JaZo
Copy link
Contributor Author

JaZo commented May 7, 2020

@driesvints good point, updated!

@taylorotwell taylorotwell merged commit 6b83045 into laravel:6.x May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants