[7.x] Fix inferred table reference for constrained#32847
Merged
Conversation
GrahamCampbell
changed the title
constrainedconstrained
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a minor bug in the logic to infer the table name for the new
constrainedmethod where it would take the string before the first matching foreign key column string.This yields incorrect table names for columns which contain the foreign key as a substring.
For example,
laravel_idea_idoramerican_idol_idyield a table name oflaravelsoramericans, respectively.This patch corrects the table name and also converts the ternary shorthand to null coalesce for a bit of modernization and symmetry.