[7.x] Restore app()->getCached*Path() absolute '/' behavior in Windows - #32969
Merged
taylorotwell merged 1 commit intoMay 26, 2020
Merged
Conversation
7.2.1 started enforcing DIRECTORY_SEPARATOR as the path prefix to be treated as absolute. For a point release, this breaks Windows environments in existing apps that use environment variables to set absolute '/'-prefixed paths. $_SERVER['APP_CONFIG_CACHE'] = '/ext/cache/config.php'; echo app()->getCachedConfigPath(); // C:\Users\Foo\projects\blog\/ext/cache/config.php This should still be '/ext/cache/config.php'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #32960
testEnvPathsAreUsedForCachePathsWhenSpecifiedis currently failing when run in Windows environments.7.2.1 started enforcing
DIRECTORY_SEPARATOR(#31985) as the path prefix to be treated as absolute. For a point release, this breaks Windows environments in existing apps that use environment variables to set absolute'/'-prefixed paths.This should still be
'/ext/cache/config.php'which PHP will likely resolve to'C:\ext\cache\config.php'.