[7.x] Tap into Http::get() even better

[hannesvdvreken]

Long time no see, friends. 👋

The Laravel HTTP client (accessible through the Http facade) uses an underlying Guzzle Client (and allows to change some of its settings). But Guzzle has a feature called middleware which provides infinite flexibility to add/inspect requests and responses going to or coming from the HTTP client. Why not allow to tap into that?

This method allows to wrap additional user-created middleware to that HandlerStack already initiated.

Example: profiling HTTP requests to a profiler like DebugBar or Clockwork

$client = new \Illuminate\Http\Client\PendingRequest();

$debugBar = new \DebugBar\StandardDebugBar();

// Get data collector.
$timeline = $debugBar->getCollector('time');

// Wrap the timeline.
$profiler = new \GuzzleHttp\Profiling\Debugbar\Profiler($timeline);

$client->withMiddleware(new \GuzzleHttp\Profiling\Middleware($profiler));

$client->send('GET', 'https://httpbin.org/status/200');

var_dump($timeline->collect());

Bonus: it's future proof (Guzzle v7 will be out soon) but middleware will remain the same.

---

cc @barryvdh @chrisrhymes @driesvints

ref https://twitter.com/chrisrhymes/status/1275378980137426950

[derekmd]

return $this->middleware ... wouldn't have any effect for a tap() callback since the return value is ignored.

Either way, this method looks much simpler by skipping tap():

$this->middleware = collect($this->middleware)->push($middleware);

return $this;

[MrRio]

This looks pretty familiar 😬 #32170

[driesvints]

@MrRio sometimes we reconsider prs if there's enough demand for it.