[7.x] Convert eloquent collection to eloquent query builder#33356
Merged
Conversation
Collaborator
|
This won't work in general. If there are lots of items in the collection, you will bust the maximum query length limit of any database. |
GrahamCampbell
requested changes
Jun 26, 2020
| throw new LogicException('can not get Eloquent QueryBuilder from an empty Collection.'); | ||
| } | ||
|
|
||
| return $model->newModelQuery()->whereKey($this->modelKeys()); |
Collaborator
There was a problem hiding this comment.
I assume you wanted "where in" and not "where". Have you tried this code for real?
Contributor
Author
Contributor
Author
is This PR has nothing to do with the update method it's just querying the models with ids so I think if there is bug in the implementation it would be in the already exist methods but loadCount method uses the same concept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some times we have a collection of models that we need to update all of them at once
I found the regular approach is to loop on every single model and make (N) times update query
I can build new query from scratch to update them all something like
Model::whereIn('id', $items->pluck('id'))->update([])but I think writing it this way is ugly what if we can convert this collection of models to a query builder looking for those models under the hood.
so we can write it like that
$items->toQuery()->update([])the following image is from a project I am working on it. I am using it as a macro and I thought it could be useful if added to the framework.