[6.x] Full PHP 8.0 Support by driesvints · Pull Request #33388 · laravel/framework

driesvints · 2020-06-30T13:19:19Z

Draft until most libraries have started to release PHP 8 compatible versions or at least dev builds.

Todo/Requirements:

deleugpn · 2020-07-11T14:53:23Z

I have started the work on opis/closure here: opis/closure#67

GrahamCampbell · 2020-07-28T13:09:30Z

Remove phpdocumentor/reflection-docblock from build

I think this will cause prefer-lowest to fail.

driesvints · 2020-07-28T13:23:50Z

@GrahamCampbell doesn't seems so.

[ci skip]

GrahamCampbell · 2020-08-09T10:12:38Z

PHP 8 broke some more stuff, so Mockery is no longer working. mockery/mockery#1088 fixes that.

driesvints · 2020-10-19T10:18:00Z

@nikic definitely something we can consider. However, I think I'm missing something as I don't see any PHP 8 builds on the https://github.com/symfony/symfony repository?

nikic · 2020-10-19T10:20:39Z

@driesvints It looks like the PHP 8 build is on Travis (nightly): https://travis-ci.org/github/symfony/symfony/builds/736971898

driesvints · 2020-10-19T13:51:55Z

@nikic we've just partially merged this PR and are working on getting the upstream branches up to date. Releases are done tomorrow. Thanks!

ollieread · 2020-10-20T11:07:55Z

@driesvints Looks like doctrine/dbal#4347 has been merged. Just fzaninotto/Faker#2063 now but it appears that the main dev for that isn't very active with that package.

driesvints · 2020-10-20T11:28:04Z

@ollieread we've contacted the maintainer to move the project to a joint organisation so we can help maintain it. Waiting for a reply now.

ollieread · 2020-10-20T15:06:21Z

Excellent @driesvints , same as I said on the faker pr, should that be required id be happy to help contribute/maintain if there's need.

Old

driesvints · 2020-10-26T11:18:18Z

Putting this in draft again for a bit longer to see if Faker lands PHP 8 support soon.

bram-pkg · 2020-10-27T09:49:38Z

Looks like a fork of Faker is gonna to have to be made (see fzaninotto/Faker#2063 (comment)).

driesvints · 2020-10-27T10:34:03Z

@bramceulemans we saw that and already making plans on how to proceed. Stay tuned.

viezel · 2020-10-27T11:22:12Z

@driesvints I think we need to update the Faker PR to FakerPHP/Faker#1

deleugpn · 2020-10-27T15:11:06Z

This is huge! Congratulations to the Laravel Team!

driesvints · 2020-10-27T15:12:53Z

@deleugpn thanks for your work on this as well 👍

driesvints changed the base branch from 7.x to 6.x June 30, 2020 13:19

GrahamCampbell changed the title ~~Test on PHP 8~~ [6.x] Test on PHP 8 Jun 30, 2020

driesvints force-pushed the php-8-builds branch from 405d21b to c7e8486 Compare July 9, 2020 13:26

driesvints force-pushed the php-8-builds branch from c7e8486 to 581983e Compare July 16, 2020 19:19

GrahamCampbell force-pushed the php-8-builds branch 2 times, most recently from 5d940e5 to 35363a1 Compare July 17, 2020 23:31

driesvints commented Jul 18, 2020

View reviewed changes

Comment thread composer.json Outdated

driesvints commented Jul 18, 2020

View reviewed changes

Comment thread src/Illuminate/Database/DPO/MySqlDriver.php Outdated

driesvints commented Jul 18, 2020

View reviewed changes

Comment thread src/Illuminate/Database/DPO/PostgresDriver.php Outdated

driesvints commented Jul 18, 2020

View reviewed changes

Comment thread src/Illuminate/Database/DPO/SQLiteDriver.php Outdated

deleugpn reviewed Jul 20, 2020

View reviewed changes

Comment thread src/Illuminate/Database/DPO/Connection.php Outdated

GrahamCampbell referenced this pull request in php/php-src Jul 29, 2020

Try to fix laravel PHP 8 incompatibility

9eb7990

[ci skip]

dkulyk suggested changes Aug 13, 2020

View reviewed changes

Comment thread src/Illuminate/Support/Collection.php Outdated

driesvints force-pushed the php-8-builds branch 3 times, most recently from a854297 to 11e6e5b Compare August 14, 2020 09:24

GrahamCampbell force-pushed the php-8-builds branch from a9d035a to 11e6e5b Compare August 24, 2020 10:42

driesvints force-pushed the php-8-builds branch 2 times, most recently from 7d0286b to 99ca90d Compare August 24, 2020 12:22

barryvdh mentioned this pull request Aug 28, 2020

Test Laravel 8 fruitcake/laravel-debugbar#1097

Merged

driesvints force-pushed the php-8-builds branch from daecf83 to 7662070 Compare September 28, 2020 15:44

rbuzzibarrios reviewed Oct 3, 2020

View reviewed changes

Comment thread src/Illuminate/Database/PDO/MySqlDriver.php Outdated

Comment thread src/Illuminate/Database/PDO/PostgresDriver.php Outdated

Comment thread src/Illuminate/Database/PDO/SQLiteDriver.php Outdated

Comment thread src/Illuminate/Database/Schema/Grammars/RenameColumn.php

driesvints force-pushed the php-8-builds branch from 111d044 to 3203e95 Compare October 5, 2020 12:33

GrahamCampbell previously requested changes Oct 8, 2020

View reviewed changes

Comment thread src/Illuminate/Support/helpers.php Outdated

driesvints force-pushed the php-8-builds branch 2 times, most recently from ff7007a to 551d587 Compare October 9, 2020 14:16

GrahamCampbell force-pushed the php-8-builds branch from a045c60 to 411a396 Compare October 19, 2020 10:35

GrahamCampbell mentioned this pull request Oct 19, 2020

[6.x] Provisional support for PHP 8.0 #34884

Merged

GrahamCampbell force-pushed the php-8-builds branch from 411a396 to 995f1e5 Compare October 19, 2020 14:01

GrahamCampbell changed the title ~~[6.x] PHP 8 Support~~ [6.x] Full PHP 8.0 Support Oct 19, 2020

Full PHP 8.0 Support

0393deb

GrahamCampbell force-pushed the php-8-builds branch from 995f1e5 to 0393deb Compare October 25, 2020 13:00

GrahamCampbell marked this pull request as ready for review October 25, 2020 13:08

driesvints commented Oct 26, 2020

View reviewed changes

Comment thread .github/workflows/tests.yml

driesvints marked this pull request as draft October 26, 2020 11:17

driesvints added 2 commits October 27, 2020 15:42

Update faker suggest

36775de

Update testbench

3551c44

driesvints marked this pull request as ready for review October 27, 2020 14:58

taylorotwell merged commit 897a471 into 6.x Oct 27, 2020

driesvints deleted the php-8-builds branch October 27, 2020 15:12

solano-catskillet mentioned this pull request Dec 18, 2020

PHP 8 geekcom/validator-docs#109

Closed

Fahmy-Mohammed mentioned this pull request Feb 19, 2021

PHP 8: Test that the agent works with frameworks that support PHP 8 newrelic/newrelic-php-agent#106

Closed

MarkVaughn mentioned this pull request Feb 3, 2022

[6.x] PHP 8 Support laravel/lumen-framework#1214

Closed

Conversation

driesvints commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deleugpn commented Jul 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GrahamCampbell commented Jul 28, 2020

Uh oh!

driesvints commented Jul 28, 2020

Uh oh!

GrahamCampbell commented Aug 9, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

driesvints commented Oct 19, 2020

Uh oh!

nikic commented Oct 19, 2020

Uh oh!

driesvints commented Oct 19, 2020

Uh oh!

ollieread commented Oct 20, 2020

Uh oh!

driesvints commented Oct 20, 2020

Uh oh!

ollieread commented Oct 20, 2020

Uh oh!

Uh oh!

driesvints commented Oct 26, 2020

Uh oh!

bram-pkg commented Oct 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

driesvints commented Oct 27, 2020

Uh oh!

viezel commented Oct 27, 2020

Uh oh!

deleugpn commented Oct 27, 2020

Uh oh!

driesvints commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

driesvints commented Jun 30, 2020 •

edited

Loading

bram-pkg commented Oct 27, 2020 •

edited

Loading