[7.x] Added ability to simulate "withCredentials" in test requests - #33497
Merged
taylorotwell merged 1 commit intoJul 10, 2020
Merged
[7.x] Added ability to simulate "withCredentials" in test requests#33497taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all
I stumbled over a missing functionality in the test cases. As stated here, XMLHttpRequests allow a flag which is named "withCredentials" to include cookies in the requests.
By default, all JSON-requests implicit use an empty cookies-array. But with the knowledge of this flag, in my opinion it makes sense to make it configurable whether json requests should include cookies or not.
This PR adds a method to test cases, which allow to use
$this->withCredentials()in a test to make alljson()-calls include the cookie-jars, which are available anyway.