[7.x] Align (fix) nested arrays support for assertViewHas & assertViewMissing#33566
Merged
Conversation
assertViewHasassertViewHas
assertViewHasassertViewHas
assertViewHasassertViewHas
assertViewHasassertViewHas / assertViewMissing
assertViewHas / assertViewMissingassertViewHas & assertViewMissing
Member
|
@claudiodekker just for future references: any bug fix can be sent to 6.x instead which will get merged with upstream branches. |
Contributor
Author
|
@driesvints Ah, I'll keep it in mind next time. I was looking at https://laravel.com/docs/7.x/contributions#which-branch, which told me to target the latest LTS? Update: Oops, I only now noticed the (LTS) flag appended to 6 😅 |
driesvints
pushed a commit
that referenced
this pull request
Jul 17, 2020
…ViewMissing` (#33566) * testAssertViewHasNested * Align assertViewMissing Co-authored-by: Claudio Dekker <claudiodekker@users.noreply.github.com>
Member
|
6.x is the current LTS version yes. I've backported this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes/fixes the inconsistent behaviour regarding nested array support introduced in #30837
It also re-aligns the
assertViewMissingmethod in a similar fashion, to be compatible with theassertViewHaschanges proposed in this PR.assertViewHas
These were already possible:
However, this one wasn't:
assertViewMissing
Similarly, this was already possible:
But this one wasn't: