[7.x] Get/Set fallback locale#33595
Merged
Merged
Conversation
GrahamCampbell
requested changes
Jul 20, 2020
| { | ||
| $this['config']->set('app.fallback_locale', $fallbackLocale); | ||
|
|
||
| $this['translator']->setFallback($fallbackLocale); |
Collaborator
There was a problem hiding this comment.
This force instantiates the translator. You should check if it has been created yet.
Member
|
@ruanpepe can you elaborate more upon the use case for this? |
Contributor
Author
|
@driesvints If you set config/app.fallback_locale to "en", all translatable string not found for language in config/app.locale will be translated to "en". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this changes, we can set the app fallback locale dinamicaly.
e.g When using 'en_US', is possible set the fallback locale to 'en', and when using 'pt_BR' set 'pt' as fallback locale.