Skip to content

[7.x] Removed quotes when setting isolation level for mysql connections#33805

Merged
taylorotwell merged 1 commit into
laravel:7.xfrom
duxthefux:isolation-level-config
Aug 10, 2020
Merged

[7.x] Removed quotes when setting isolation level for mysql connections#33805
taylorotwell merged 1 commit into
laravel:7.xfrom
duxthefux:isolation-level-config

Conversation

@duxthefux

Copy link
Copy Markdown
Contributor

Removed unnecessary quotes, which cause mysql error if isolation_level-config is provided.

@duxthefux

duxthefux commented Aug 10, 2020

Copy link
Copy Markdown
Contributor Author

@taylorotwell sry for the obsolete quotes, I removed them in another branch where we run tests against real mysql server, and missed to apply the change also to the MR. Sorry for that! 🤦

EDIT: Added test

@duxthefux duxthefux force-pushed the isolation-level-config branch from 40b709d to 2f573a7 Compare August 10, 2020 09:30
@taylorotwell taylorotwell merged commit bdf827c into laravel:7.x Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants