[6.x] Fix defaultTimezone not respected in scheduled Events

[sodoardi]

Update CallbackEvent
-> CallbackEvents were not injected with the timezone on construction making them ignore the schedulers timezone on $event->between() settings

[GrahamCampbell]

I have re-targetted to Laravel 8, because upgrading to version 3 of the cron package is a major breaking change, because they have changed how things work since version 2, and we already upgraded Laravel 8 only, for that reason.

[GrahamCampbell]

I have also rebased your PR, so the composer.json updates don't show up anymore.

[sodoardi]

@GrahamCampbell I took out the the cron package change and created a new PR without the update, this is a new PR with only the CallbackEvent changes

[GrahamCampbell]

Ah, I see, so you're saying the upgraded version was not necessary?

[sodoardi]

Ah, I see, so you're saying the upgraded version was not necessary?

It is necessary for the other bug :), which affects all dailyAt() etc. which evaluate in the cron expression
this PR fixes the bug regarding between() for CallbackEvents which happens in the filter

[GrahamCampbell]

It is necessary for the other bug

Right, I see. I don't think the upstream package authors considered that to be a bug, but decided to change the behaviour in v3 to "what you would expect", and considered it a breaking change. For this reason, you will have to wait till Laravel 8 to get v3 of that package. It should still be possible to work around the issue though. There should be some information about the changes on the upstream repo. :)

[sodoardi]

Right, I see. I don't think the upstream package authors considered that to be a bug,

yea unfortunately they fixed together with the major change, I asked them to backport the fix to the 2.x versions, lets see. Its in the changelog fixes:

• Fixed issue where logic for dropping seconds to 0 could lead to a timezone change

but decided to change the behaviour in v3 to "what you would expect", and considered it a breaking change. For this reason, you will have to wait till Laravel 8 to get v3 of that package. It should still be possible to work around the issue though. There should be some information about the changes on the upstream repo. :)

in my project im doing the good old dragonmark/cron-expression:"3.0.0 as 2.4.0" hack, since the breaking change in behaviour doesn't affect my project