[7.x] validate email with custom class#33835
Merged
taylorotwell merged 2 commits intolaravel:7.xfrom Aug 12, 2020
Gummibeer:ft-validate-email-with-custom-class
Merged
[7.x] validate email with custom class#33835taylorotwell merged 2 commits intolaravel:7.xfrom Gummibeer:ft-validate-email-with-custom-class
taylorotwell merged 2 commits intolaravel:7.xfrom
Gummibeer:ft-validate-email-with-custom-class
Conversation
driesvints
approved these changes
Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying egulias/email-validator package allows to add custom validators by implementing the
Egulias\EmailValidator\Validation\EmailValidationinterface.But right now it's not possible to use the existing
emailrule to call these custom validators.This PR allows to pass in a FQCN which is resolved by the container and returned.
This example will call the
rfcanddnsvalidator like before but also callMyCustomValidator.That's useful if you want to limit registration to a given email domain, filter trashmails or whatever you want to add on top.