[7.x] Fix the dump method for LazyCollection#33944
Merged
taylorotwell merged 1 commit intolaravel:7.xfrom Aug 20, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dumpmethod is currently broken when called on a lazy collection.This PR fixes it, with tests.
I made a small change: calling
dumpon a regularCollectionwill no longer dump the actual collection instance - only its values.The reason I did this is because for lazy collections, it makes no sense to dump the collection instance, since it won't show you any of its values (they haven't been generated yet). For consistency, the regular collection class now also only dumps its values, which is probably anyhow what you're after.