[7.x] Introduced basic padding (both, left, right) methods to Str and Stringable…#34053
Merged
Conversation
telkins
changed the title
Member
|
@telkins can you also PR these to the docs? Thanks! |
Contributor
Author
@driesvints Only if I can get my hands on Blade UI Kit...right now...! 😜 Kidding...of course. I'll try to get that done this weekend, if that's OK. Thx. |
Contributor
Author
@driesvints I just decided to try to get it out of the way right now. Hope it's OK. Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically, this brings PHP's
str_pad()into Laravel'sStrandStringableclasses. I looked quickly for such support in the code and the docs and couldn't find any. Likewise, I couldn't find any previous PRs (accepted or rejected) that mentionedstr_pad.I added tests, but no documentation. I don't mind updating the docs once I know it's likely to be accepted. Hopefully that makes sense.
I explicitly provided the pad type argument when it matches the default. I thought about removing it, but decided that being explicit might be the better choice after all.
Any feedback is welcome.
Thx. 🤓