Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Ensure ShouldBeUniqueUntilProcessing job lock is released once #35270

Merged
merged 2 commits into from Nov 18, 2020
Merged

[8.x] Ensure ShouldBeUniqueUntilProcessing job lock is released once #35270

merged 2 commits into from Nov 18, 2020

Conversation

paras-malhotra
Copy link
Contributor

@paras-malhotra paras-malhotra commented Nov 18, 2020

Based on our conversation in #35255, I checked the code and the failed method is called on a freshly resolved instance. So, I've submitted another PR to fix it so that the lock release only happens once for ShouldBeUniqueUntilProcessing jobs.

@paras-malhotra paras-malhotra changed the title [8.x] Ensure unique lock is released once [8.x] Ensure UniqueUntilProcessing lock is released once Nov 18, 2020
@paras-malhotra paras-malhotra changed the title [8.x] Ensure UniqueUntilProcessing lock is released once [8.x] Ensure ShouldBeUniqueUntilProcessing job lock is released once Nov 18, 2020
@taylorotwell taylorotwell merged commit d09bf01 into laravel:8.x Nov 18, 2020
13 checks passed
@paras-malhotra paras-malhotra deleted the release_once branch Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants