Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Use --no-owner and --no-acl with pg_restore #35309

Merged
merged 1 commit into from Nov 21, 2020

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Nov 20, 2020

Removed

  • Removes the --no-owner from the dump() command, as it's a duplicate already set in the baseDumpCommand base command

Changed

  • Changes the PostgresSchemaState::load() to also use --no-owner and --no-acl flags in the pg_restore command (which are also used in the schema:dump, see comment above)

We were not able to run the migrate command on GitHub CI using the dump file without passing the --no-owner and --no-acl flags, as CI had a different DB user. The Heroku docs - for reference - also suggest using those flags with pg_restore.

Co-authored-by: @funkymonk91

@tonysm tonysm force-pushed the schema-load branch 2 times, most recently from a1d61e2 to aa75618 Compare Nov 20, 2020
Co-authored-by: Sean Frankruyter <s.frankruyter@gmail.com>
@GrahamCampbell GrahamCampbell changed the title Use --no-owner and --no-acl with pg_restore [8.x] Use --no-owner and --no-acl with pg_restore Nov 20, 2020
@taylorotwell taylorotwell merged commit 380ef43 into laravel:8.x Nov 21, 2020
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants