[6.x] Fix generic DetectsLostConnection string#35323
Merged
taylorotwell merged 1 commit intoNov 23, 2020
Merged
Conversation
This was referenced Mar 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: #31539 introduced a bug #35321 and potentially more bugs that haven't been reported yet. The issue is that the
DetectsLostConnectionstring added ("connection refused") is way too generic and may be caused by any TCP/IP service that's unable to connect (isn't limited to lost DB connections). Based on the original PR stack trace, I've narrowed it down to make it specific to lost database connections.Closes #35321.