-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Delete existing links that are broken #36470
Merged
taylorotwell
merged 1 commit into
laravel:6.x
from
eXolnet:bugfix/remove-dead-symlinks-6x
Mar 5, 2021
Merged
[6.x] Delete existing links that are broken #36470
taylorotwell
merged 1 commit into
laravel:6.x
from
eXolnet:bugfix/remove-dead-symlinks-6x
Mar 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a link exists but is broken, `file_exists($link)` return false. And when `symlink($link, $target)` is called on a broken link, a PHP Warning is returned and the link is not updated. To fix this, we add an additional check using `is_link($link)` (which return true, even if the link is broken) to detect and delete broken links.
GrahamCampbell
changed the title
Delete existing links that are broken
[6.x] Delete existing links that are broken
Mar 4, 2021
This was referenced Mar 10, 2021
This was referenced Mar 17, 2021
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to fix an issue that occur when the storage link already exists but is somehow broken. By "broken", I mean link that point to a non-existing target.
When running the
storage:link
command, we get an error message and the link is not updated.To fix this issue, we add an additional check to detect and delete broken links when running the
storage:link
command.Implementation details
When a link exists but is broken,
file_exists($link)
return false. And whensymlink($link, $target)
is called on a broken link, a PHP Warning is returned and the link is not updated. To fix this, we add an additional check usingis_link($link)
(which return true, even if the link is broken) to detect and delete broken links.