[6.x] Fixes the issue using cache:clear with PhpRedis and a clustered Redis instance. #36665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Redis instance, by updating the PhpRedisConnection flushdb method to use the already open/configured clients.
J5Dev
changed the title
driesvints
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simply a replication of the fix by @willbrowningme in MR #36281 which was already merged to the 8.x release branch.
The issue is however still unfixed within the 6.x LTS release, so this PR is a simple replication of the work previously undertaken to allow for the fix to be merged into the 6.x branch.
I have tested that as with the other branch, these changes not only work, but also have no adverse affects. In addition to replicating the tests undertaken by @willbrowningme I have also tested this within a Kubernetes environment running both php-fpm 7.3 & 7.4 tests alongside a clustered Redis instance.