[9.x] Add support for passing array as the second parameter for the group method.#40945
Merged
taylorotwell merged 2 commits intolaravel:9.xfrom Feb 10, 2022
hossein-zare:9.x
Merged
[9.x] Add support for passing array as the second parameter for the group method.#40945taylorotwell merged 2 commits intolaravel:9.xfrom hossein-zare:9.x
taylorotwell merged 2 commits intolaravel:9.xfrom
hossein-zare:9.x
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi.
What's this PR for? (example):
in the
RouteServiceProviderfile:can be written as follows
Both of them with the same middleware and namespace in just an array.
Reasons why this PR won't break other features:
The original
groupmethod only accepts\Closure|stringas the second parameter which is$routes, so passing an array won't mess around.The original group:
It's only one simple commit, I also tested it on a real/ready project.
I ❤ Laravel