[9.x] Eloquent: firstWhere returns Object instead of NULL#41099
Merged
Conversation
marvinrabe
changed the title
Member
|
This definitely isn't wanted and changes the behavior of this method to accept more parameters than needed. |
driesvints
approved these changes
Feb 18, 2022
driesvints
left a comment
driesvints
left a comment
Member
There was a problem hiding this comment.
Can confirm this fixes the issue for me as well. @marvinrabe can you maybe also add a test?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41098